- 
                Notifications
    You must be signed in to change notification settings 
- Fork 242
feat: allow to ignore volumes during reconciliation #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| If this is going in the right direction, I can complete the other entries discussed in #1078. 
 | 
35f412e    to
    2a21ee7      
    Compare
  
    | Not sure if there is a notification about a draft. Could you give me a feedback, if this goes into the right direction, @brokenpip3? | 
| 
 yes sorry, will take a look asap! | 
| Sorry if took me a while, the PR looks good as start, we can continue like this for the others :) so we can express it like that: kind: Jenkins
metadata:
  name: example
spec:
  lifecycle:
    ignore:
      volumes:
        - /var/lib/jenkins/cache
        - /var/lib/jenkins/tmp
      envs:
       - FOOBARyou can continue to adjust the unit tests and I can instead add the e2e tests for cover your changes, don't worry about that part, it's something I can complete. thanks again for your contribution! | 
It allows to specify ignores values. Note that additional values are ignored anyways, this ignore annotation only handles different values or additional annotations.
41dacf1    to
    a334db7      
    Compare
  
    | I have adapted your changes and implemented ignoring of annotations and volumes. | 
Changes
This is work in progress.
Allows to ignore volumes.
Closes #1078
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.